Don't remove still-referenced files when unconfiguring recipes #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
fix-unconfig
branch
from
73cedb4 to
6443e31
Compare
fabpot
added a commit
that referenced
this pull request
Aug 22, 2025
…wouterj) This PR was merged into the 2.x branch. Discussion ---------- Don't remove still-referenced files when updating recipes A twin to #1054 When a recipe removes a file in a newer recipe version, we should also check if other recipes still reference that file. Real use-case: This occurs when you need to keep the PhpunitBridge in 7.3 (e.g. you need the clock mock). Commits ------- 03ac318 Don't remove still-referenced files when updating recipes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #706
Fixes broken logic added in #451, which didn't account for folders.
The new logic uses only the symfony.lock file and not the recipe anymore to decide which files to remove.